Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-9: add bank_account_type #1344

Merged
merged 2 commits into from
Feb 10, 2023
Merged

SEP-9: add bank_account_type #1344

merged 2 commits into from
Feb 10, 2023

Conversation

JakeUrban
Copy link
Contributor

@JakeUrban JakeUrban commented Feb 10, 2023

Adds bank_account_type to the list of SEP-9 fields, with initial supported values of checking or savings. Some jurisdictions have banking systems that require that the account type be specified in addition to the account number.

Note that bank_account_type does not indicate the format of bank_account_number, and should not be used to validate bank_account_number.

If an anchor needs to be able to validate an account identifier, it should use other SEP-9 fields added specifically for the format they're looking to validate, such as cbu_number or clabe_number. These fields often contain pieces of information other than the user's account number with their bank.

For example, CBU numbers contain identifiers for the bank, the bank branch, the type of account, and the account number itself. Instead of trying to decompose CBU numbers and passing each piece via the bank_account_number, bank_number, bank_branch_number, and other SEP-9 fields, it is much easier for businesses operating in those jurisdictions to accept account identifiers in the formats that are common in those jurisdictions.

@JakeUrban
Copy link
Contributor Author

@theclabs this is relevant to the comment you made on #1339.

cc @lucaszanotelli

Copy link

@reecexlm reecexlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeUrban JakeUrban merged commit 387b5fd into master Feb 10, 2023
@JakeUrban JakeUrban deleted the sep9-bank-account-type branch February 10, 2023 21:42
@lijamie98
Copy link
Contributor

@JakeUrban Do you consider having the composite bank number that contains both the bank_account_type and the bank_account_number such as bank_account_number is checking:123-456-7890?

@JakeUrban
Copy link
Contributor Author

We've entertained the idea of defining our own formats for composite fields in SEP-9 here, but ultimately decided against it. We do have some composite fields though, like clabe_number and cbu_number, the difference is that their formats have been defined by the governments of those jurisdictions.

Copy link

@Missjones2829 Missjones2829 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants